The implementation is complete and I'd like you to review it. 🙇

@liurenjie1024 Thanks for the review! I've addressed the comments you made. 🙇🏼

@liurenjie1024 May I ask a question?
Currently, to comply with iceberg::CatalogBuilder, implementing Default is required. Why exactly is Default necessary? I understand it's needed for the load function in the iceberg-loader-catalog crate, but are there any other reasons?

SqlCatalog requires iceberg::FileIO, but implementing Default to allow users to select the storage location proves challenging. Currently, I'm considering implementing it by passing iceberg::FileIO as an argument to the initializer.

impl SqlCatalogBuilder {
    pub fn new(file_io: FileIO) -> Self {
        ...
    }
}

If possible, I'd like to remove Default from the iceberg::CatalogBuilder definition.

Hi, @335g I'm not convinced that we should remove Default for CatalogBuilder, as the default method provides a default constructor for it.

SqlCatalog requires iceberg::FileIO, but implementing Default to allow users to select the storage location proves challenging.

It's CatalogBuilder that requires implementing Default, not SqlCatalog. I took a look at the code and I think storing FileIO in SqlCatalogConfig is incorrect, FileIO should be inferred from warehouse location.

Hi, @liurenjie1024 Thanks for the comment. I realized I didn't fully understand the previous comment. I've made some adjustments to the implementation - how does this look?

Resolved conflict